Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 63: libgettextpo version accessor (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by georgeyk
Modified:
1 year, 4 months ago
Reviewers:
dwaynebailey, friedel
SVN Base:
https://translate.svn.sourceforge.net/svnroot/translate/src/trunk/

Description

Add a libgettexpo version accessor and change how we handle certain message unit
(its details) based on the libgettext version.

Patch Set 1

Patch Set 2 : Fixed the calculation of the subminor version

Total comments: 2
Raw unified diffs Stats Side-by-side diffs with inline comments Delta from patch set
translate/storage/cpo.py 3 chunks 51 lines 2 comments 1

Messages

Total messages: 2
dwaynebailey
I'm happy with this and would like to see it committed. http://zuza.appspot.com/63/diff/3/22 File translate/storage/cpo.py (right): ...
1 year, 4 months ago
georgeyk
1 year, 4 months ago
On 2008/07/17 12:33:59, dwaynebailey wrote:
> I'm happy with this and would like to see it committed.
> 
> http://zuza.appspot.com/63/diff/3/22
> File translate/storage/cpo.py (right):
> 
> http://zuza.appspot.com/63/diff/3/22#newcode172
> Line 172: return major, minor, subminor
> Glad to see we are future proof.  Nice.
> 
> http://zuza.appspot.com/63/diff/3/22#newcode358
> Line 358: needs_space = get_libgettextpo_version() < (0, 17, 0)
> Great :)

Just as a remark for the future, Friedel have commited this patch.
Sign in to reply to this message.

Powered by Google App Engine
This is Rietveld r159