Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 81: Fix CPO memory leak

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by georgeyk
Modified:
1 year, 3 months ago
Reviewers:
dwaynebailey
SVN Base:
https://translate.svn.sourceforge.net/svnroot/translate/src/trunk/

Description

Patch Set 1

Patch Set 2 : Using low leve accessors

Patch Set 3 : Added some tests workarounds

Patch Set 4 : Added tests

Patch Set 5 : Fix addlocation method

Total comments: 8
Raw unified diffs Stats Side-by-side diffs with inline comments Delta from patch set
translate/storage/cpo.py 9 chunks 158 lines 6 comments 1 2 3 4
translate/storage/test_cpo.py 1 chunk 34 lines 2 comments 4

Messages

Total messages: 3
georgeyk
This is a very incomplete patch. It seems to fix the memory leak, but breaks ...
1 year, 3 months ago
dwaynebailey
http://zuza.appspot.com/81/diff/441/642 File translate/storage/cpo.py (left): http://zuza.appspot.com/81/diff/441/642#oldcode123 Line 123: gpo.po_message_add_filepos.argtypes = [c_int, STRING, c_int] I assume this ...
1 year, 3 months ago
georgeyk
1 year, 3 months ago
I'm splitting this patch, so you or someone else can review it in small pieces.
http://zuza.appspot.com/101
http://zuza.appspot.com/102
http://zuza.appspot.com/103

Thanks for the review. I'll update this patch when all the others was correct.
Sign in to reply to this message.

Powered by Google App Engine
This is Rietveld r159